Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-w: Add support for v flag #578

Merged
merged 4 commits into from
Sep 14, 2023
Merged

prefer-w: Add support for v flag #578

merged 4 commits into from
Sep 14, 2023

Conversation

RunDevelopment
Copy link
Collaborator

Besides adding support for the v flag, I also fixed a bug. \D was incorrectly detected as \d in isDigitRangeOrSet.

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

🦋 Changeset detected

Latest commit: 48da470

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-regexp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RunDevelopment RunDevelopment marked this pull request as draft September 6, 2023 21:12
@RunDevelopment
Copy link
Collaborator Author

Still a draft because I'm working on improving the API of UnicodeSet right now. I'm making it more CharSet-like to make the migration to toUnicodeSet easier.

@RunDevelopment RunDevelopment marked this pull request as ready for review September 14, 2023 10:40
Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 041bd66 into master Sep 14, 2023
5 checks passed
@ota-meshi ota-meshi deleted the prefer-w-v-flag branch September 14, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants