Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Unset SOURCE_DATE_EPOCH #2407

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Conversation

smcv
Copy link
Contributor

@smcv smcv commented Jul 26, 2021

Some distributions set this during build in order to have reproducible
builds from the same source code: for example, Debian uses the date
from debian/changelog.

However, some of our tests assume that ostree commit will result in
a commit with the current date/time, and SOURCE_DATE_EPOCH breaks that
assumption. Unset it for our build-time tests.

Resolves: #2405

Some distributions set this during build in order to have reproducible
builds from the same source code: for example, Debian uses the date
from debian/changelog.

However, some of our tests assume that `ostree commit` will result in
a commit with the current date/time, and SOURCE_DATE_EPOCH breaks that
assumption. Unset it for our build-time tests.

Resolves: ostreedev#2405
Signed-off-by: Simon McVittie <smcv@collabora.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2021

Hi @smcv. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smcv smcv marked this pull request as draft July 26, 2021 10:51
@smcv
Copy link
Contributor Author

smcv commented Jul 26, 2021

I'm trying this with a Debian package build, but I think it'll work.

@lucab
Copy link
Member

lucab commented Jul 26, 2021

/ok-to-test

@smcv
Copy link
Contributor Author

smcv commented Jul 26, 2021

A modified Debian package build, reverting my packaging-level workaround for #2405 and adding this patch instead, was successful.

@smcv smcv marked this pull request as ready for review July 26, 2021 11:03
@lucab lucab merged commit 835b114 into ostreedev:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail with SOURCE_DATE_EPOCH set
2 participants