-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ announce where results are written #4132
Conversation
Before this change, when running with '-o foo' the output would end with: ``` RESULTS ------- ``` This was rather confusing. There's of course many ways to make this more clear, this commit adds a log line announcing where the output is written to: ``` RESULTS ------- Writing to foo ``` Signed-off-by: Arnout Engelen <arnout@bzzt.net>
4478005
to
e76991f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I believe there is a lint that is supposed to prevent new print statements, not sure why it isn't complaining here...
The linter was added primarily from people writing to Lines 93 to 96 in 3da6db5
|
Before this change, when running with '-o foo' the output would end with: ``` RESULTS ------- ``` This was rather confusing. There's of course many ways to make this more clear, this commit adds a log line announcing where the output is written to: ``` RESULTS ------- Writing to foo ``` Signed-off-by: Arnout Engelen <arnout@bzzt.net> Signed-off-by: balteraivshay <avishay.balter@gmail.com>
What kind of change does this PR introduce?
Minor usability improvement
What is the current behavior?
When running with '-o foo' the output would end with:
What is the new behavior (if this is a feature change)?**
This was rather confusing. There's of course many ways to make this more clear, this commit adds a log line announcing where the output is written to:
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)