-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 refactor: reorder functions to enhance readability #3880
🌱 refactor: reorder functions to enhance readability #3880
Conversation
9c7a086
to
4e98b39
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3880 +/- ##
==========================================
- Coverage 74.87% 70.33% -4.55%
==========================================
Files 223 223
Lines 15993 15993
==========================================
- Hits 11975 11248 -727
- Misses 3254 4029 +775
+ Partials 764 716 -48 |
This file will be changing substantially in #3759. I recommend holding off until after that to see if these changes are still necessary. |
This pull request has been marked stale because it has been open for 10 days with no activity |
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
3d400c9
to
e19af7e
Compare
@spencerschrock I've rebased it after #3759 . Please take a look if that makes sense to you. |
This pull request has been marked stale because it has been open for 10 days with no activity |
This is a refactor PR that only reorder some of the functions on
checks/evaluation/branch_protection.go
andclients/githubrepo/branches.go
to enhance readability. It ensures that called functions are always after their caller; I also tried to bring together the functions that were meaningfully similar.I'm doing this mostly because I felt some difficulty understanding and navigating around the functions when working on #3499.
What kind of change does this PR introduce?
It's a refactor
This PR does not change any behavior or bring any breaking change