Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add branch protection evaluation #3759

Merged
merged 25 commits into from
Feb 28, 2024
Merged

🌱 Add branch protection evaluation #3759

merged 25 commits into from
Feb 28, 2024

Commits on Feb 24, 2024

  1. 🌱 Add branch protection evaluation 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e81a9ae View commit details
    Browse the repository at this point in the history

  2. make helper for getting the branchName 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    6a79f17 View commit details
    Browse the repository at this point in the history

  3. move check for branch name 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c29bb43 View commit details
    Browse the repository at this point in the history

  4. define size of slice 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    627fdae View commit details
    Browse the repository at this point in the history

  5. add probe for protected branches. 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e06bb06 View commit details
    Browse the repository at this point in the history

  6. change 'basicNonAdminProtection' to 'deleteAndForcePushProtection' 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    de9a374 View commit details
    Browse the repository at this point in the history

  7. fix markdown in text field in def.yml 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    3676de3 View commit details
    Browse the repository at this point in the history

  8. remove duplicate conditional 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    2999537 View commit details
    Browse the repository at this point in the history

  9. remove redundant 'protected' value from 'requiresCodeOwnersReview' probe 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    d34ae27 View commit details
    Browse the repository at this point in the history

  10. remove protected values from probes 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    5c98388 View commit details
    Browse the repository at this point in the history

  11. Bring back negative outcome in case of 0 codeowners files 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    75c18eb View commit details
    Browse the repository at this point in the history

  12. log based on whether branches are protected 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    48c1b53 View commit details
    Browse the repository at this point in the history

  13. remove unnecessary test 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    2d26086 View commit details
    Browse the repository at this point in the history

  14. debug failing tests 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    00acf66 View commit details
    Browse the repository at this point in the history

  15. Fix failing tests 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    175d28f View commit details
    Browse the repository at this point in the history

  16. rename test 

    Signed-off-by: Adam Korczynski <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    aeb5a55 View commit details
    Browse the repository at this point in the history

  17. update to with latest upstream changes 

    Signed-off-by: AdamKorcz <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e5b1666 View commit details
    Browse the repository at this point in the history

  18. fix linting issues 

    Signed-off-by: AdamKorcz <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    21fdf63 View commit details
    Browse the repository at this point in the history

  19. remove tests that represent impossible scenarios 

    Signed-off-by: AdamKorcz <adam@adalogics.com>
    @AdamKorcz
    AdamKorcz committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    a4896eb View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. remove protected finding value 

    This was discussed previously, but accidentally reverted

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    93fbbc1 View commit details
    Browse the repository at this point in the history

  2. Revert "debug failing tests" 

    This reverts commit 00acf66.

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6280031 View commit details
    Browse the repository at this point in the history

  3. use branchName key for branch name 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b51e620 View commit details
    Browse the repository at this point in the history

  4. include number of reviews in INFO 

    this was previously included by the old evaluation code

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8358285 View commit details
    Browse the repository at this point in the history

  5. reduce info count by 1 

    requiring codeowners without a corresponding file used to give 1 INFO and 1 WARN
now it only gives 1 WARN

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6123cef View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into pr/AdamKorcz/3759 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f706b69 View commit details
    Browse the repository at this point in the history