Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Use new project name in Copyright notices #2505

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

lehors
Copy link
Contributor

@lehors lehors commented Dec 1, 2022

Signed-off-by: Arnaud J Le Hors lehors@us.ibm.com

What kind of change does this PR introduce?

This is a followup to PR #2428. This PR updates all the copyright notices to use the new project name OpenSSF Scorecard.

What is the current behavior?

Copyright attributed to: "Security Scorecard Authors"

What is the new behavior (if this is a feature change)?**

Copyright attributed to: "OpenSSF Scorecard Authors"

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

Only when it comes to the copyright in the source and documentation.

Use new project name in Copyright notices

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #2505 (104d75a) into main (d11772d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2505   +/-   ##
=======================================
  Coverage   40.70%   40.70%           
=======================================
  Files         115      115           
  Lines        9593     9593           
=======================================
  Hits         3905     3905           
  Misses       5409     5409           
  Partials      279      279           

@laurentsimon laurentsimon enabled auto-merge (squash) December 1, 2022 20:16
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Integration tests success for
[7dcd025]
(https://github.com/ossf/scorecard/actions/runs/3596112240)

@spencerschrock
Copy link
Contributor

Just curious, how did you generate the changes? I spot checked the 481 changes with some git diff and grep, and seems fine.

@lehors lehors temporarily deployed to integration-test December 1, 2022 22:15 Inactive
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Integration tests success for
[104d75a]
(https://github.com/ossf/scorecard/actions/runs/3596319478)

Copy link
Contributor

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Everything looked normal when checking with:

git diff upstream/main | grep "^+" | grep -v "^+++" | grep -vi Copyright

And got a LGTM in the other PR too: #2428 (comment)

@laurentsimon laurentsimon merged commit 2169bc4 into ossf:main Dec 1, 2022
@lehors
Copy link
Contributor Author

lehors commented Dec 2, 2022

Just curious, how did you generate the changes? I spot checked the 481 changes with some git diff and grep, and seems fine.

Sorry for the late reply, I'm in Europe at the moment. The command I used was:
git grep -i "security scorecard"|grep -v faq.md|cut -f1 -d\:|while read f;do sed 's/Security Scorecard/OpenSSF Scorecard/' <$f >tmp && mv tmp $f;done

faq.md had to be excluded because it contains the last occurence of "security scorecard" in the entry about the change of name and doesn't have a copyright notice (maybe that should be fixed).
I then checked the diff with a simple 'git diff' before committing the change.

Thanks for reviewing and approving this PR.

raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants