📖 Patch fix: updated makefile to include unit-test and unit-test-attestor and cont… #2366
Conversation
dvbnrg
requested review from
olivekl,
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
dvbnrg
changed the title
|
Integration tests success for |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
=======================================
Coverage 40.61% 40.61%
=======================================
Files 112 112
Lines 8831 8831
=======================================
Hits 3587 3587
Misses 4984 4984
Partials 260 260 |
dvbnrg
changed the title
There was a problem hiding this comment.
LGTM, just sign-off your commit to take care of the DCO check
|
hi @spencerschrock , friendly reminder to label this PR with "hacktoberfest-accepted" before merging it in. thanks! |
|
Integration tests success for |
|
Integration tests success for |
|
Integration tests success for |
|
Integration tests success for |
|
Integration tests success for |
|
I see signoffs in your latest commits, thanks! But the DCO bot will fail until all commits are signed off, so you'll need to rebase. |
naveensrinivasan
force-pushed
the
issue-2330
branch
from
9c4257e
to
aab5a1d
Compare
|
Integration tests success for |
…ributing doc to include e2e-pat Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com>
Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com>
|
Integration tests success for |
|
Integration tests success for |
…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> * updated docs Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> Co-authored-by: Dave Banerjee <Dave.Banerjee@ibm.com> Signed-off-by: latortuga <latortugaaaa>
…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> * updated docs Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> Co-authored-by: Dave Banerjee <Dave.Banerjee@ibm.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> * updated docs Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> Co-authored-by: Dave Banerjee <Dave.Banerjee@ibm.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> * updated docs Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com> Co-authored-by: Dave Banerjee <Dave.Banerjee@ibm.com>
…ributing doc to include e2e-pat
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Running make all now runs unit-test and unit-test-attestor
Which issue(s) this PR fixes
This PR fixes: #2330
Fixes #2330
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)