webapp: Separate functions/constructors db by projects #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
arthurscchan
force-pushed
the
separate-function-db
branch
from
55a4474
to
56f6c0c
Compare
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
DavidKorczynski
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current logic, the DB JSON file for functions and constructors contains is combined into two JSON files which contain all functions/constructors of all projects. This is not a good practice because this makes the whole JSON file so large and hard to maintain. This PR alters the approach by saving the functions/constructors in separate files for each project. In addition, the functions/constructors are not loaded to the data_storage.py during webapp initialisation. Instead, the needed project functions/constructors are retrieved lively when it is requested. With this new setting, four functions have been provided in data_storage. Two of them request a project name and only retrieve the functions/constructors for the target project. The other two preserve the old functionality by going through all functions/constructors JSON for all projects and returning a full functions/constructors list same as before.