Fix coverage calculation for JVM projects #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
arthurscchan
force-pushed
the
fix-coverage-report
branch
3 times, most recently
from
27f30a7
to
dfdefa0
Compare
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
arthurscchan
force-pushed
the
fix-coverage-report
branch
from
dfdefa0
to
a5e0572
Compare
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
DavidKorczynski
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is found that the code coverage report calculation for JVM does not reflect the real data correctly. After some analysis of the code, it is believed that the current coverage calculation and extraction from the jacoco.xml only consider items in terms of source files but not methods. This cause separate methods inherit a wrong coverage calculation. This PR proposes a revamp on the coverage calculation for JVM projects to consider cov_map on separate methods instead of the whole source files. This is necessary to retrieve correct coverage information for each methods and that information is needed for further post-processing and the candidate choosing process for oss-fuzz-gen.