ScanController: Stop mixing provenance resolution issues of different type #7078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
scan-controller-separate-resolution-issues
branch
from
3bf12c2
to
b3d8b60
Compare
mnonnenmacher
requested changes
Jun 1, 2023
fviernau
force-pushed
the
scan-controller-separate-resolution-issues
branch
from
b3d8b60
to
3550c58
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7078 +/- ##
=========================================
Coverage 64.61% 64.61%
Complexity 1969 1969
=========================================
Files 331 331
Lines 16654 16654
Branches 2387 2387
=========================================
Hits 10761 10761
Misses 4846 4846
Partials 1047 1047
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
reviewed
Jun 2, 2023
fviernau
force-pushed
the
scan-controller-separate-resolution-issues
branch
from
3550c58
to
89631ce
Compare
Separate the issues for package provenance resolution and nested provenance resolution. This brings the following benefits: 1. It makes clear that there can be at most one package provenance resolution issue per ID. 2. It makes clear that there can be at most one nested provenance resolution issue per provenance. 3. Nested provenance resolution issues no more get duplicated for each package using that provenance. This change is a preparation for separating these issue in a similar way in the `ScannerRun`. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Prepare for using them in an upcoming change. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
scan-controller-separate-resolution-issues
branch
from
89631ce
to
3eb3c3d
Compare
mnonnenmacher
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of #5950.