refactor(stack): Simplify toPackage() a bit

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
oss-review-toolkit · Jul 3, 2024 · 28fe497 · 28fe497
1 parent 34e7e95
commit 28fe497
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/plugins/package-managers/stack/src/main/kotlin/Stack.kt b/plugins/package-managers/stack/src/main/kotlin/Stack.kt
@@ -178,22 +178,15 @@ class Stack(
             version = version
         )
 
-        val fallback = Package.EMPTY.copy(
+        if (location == null || location.type == HACKAGE_PACKAGE_TYPE) {
+            downloadCabalFile(id)?.let { return parseCabalFile(it) }
+        }
+
+        return Package.EMPTY.copy(
             id = id,
             purl = id.toPurl(),
             declaredLicenses = setOf(license)
         )
-
-        return when (location?.type) {
-            null, HACKAGE_PACKAGE_TYPE -> {
-                // Enrich the package with additional metadata from Hackage.
-                downloadCabalFile(id)?.let {
-                    parseCabalFile(it)
-                } ?: fallback
-            }
-
-            else -> fallback
-        }
     }
 
     private fun getPackageUrl(name: String, version: String) = "https://hackage.haskell.org/package/$name-$version"