Skip to content

Commit

Permalink
chore(composer): Remove an uncessary log warning
Browse files Browse the repository at this point in the history
The warning is not necessary because it is not actionable. So, remove
it to simplify an upcoming change.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
  • Loading branch information
fviernau authored and sschuberth committed Aug 7, 2024
1 parent 37e0e5c commit 0454248
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
6 changes: 0 additions & 6 deletions plugins/package-managers/composer/src/main/kotlin/Composer.kt
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,6 @@ class Composer(
val homepageUrl = pkgInfo.homepage.orEmpty()
val vcsFromPackage = parseVcsInfo(pkgInfo)

// Just warn if the version is missing as Composer itself declares it as optional, see
// https://getcomposer.org/doc/04-schema.md#version.
if (version.isEmpty()) {
logger.warn { "No version information found for package $rawName." }
}

packages[rawName] = Package(
id = Identifier(
type = "Composer",
Expand Down
1 change: 1 addition & 0 deletions plugins/package-managers/composer/src/main/kotlin/Model.kt
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ data class Lockfile(
@JsonIgnoreProperties(ignoreUnknown = true)
data class PackageInfo(
val name: String?,
// See https://getcomposer.org/doc/04-schema.md#version.
val version: String?,
val homepage: String?,
val description: String?,
Expand Down

0 comments on commit 0454248

Please sign in to comment.