Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins to view the buoy on RViz #6

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Plugins to view the buoy on RViz #6

merged 2 commits into from
Jun 13, 2022

Conversation

quarkytale
Copy link
Contributor

Adding sdformat_urdf to the project

@quarkytale
adding parser plugin to project
383cd63 
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@quarkytale quarkytale changed the title View the buoy on RViz Plugins to view the buoy on RViz May 25, 2022
@quarkytale quarkytale requested a review from chapulina May 25, 2022 03:10
@quarkytale
Copy link
Contributor Author

Installing from source might not be required if we just end up using the binaries

@chapulina
Copy link
Contributor

chapulina commented Jun 3, 2022 •
edited
Loading

It turns out that we should actually be compiling sdformat_urdf from source instead of using the debs. The debs are being compiled against Citadel 😱 , and we need to use then with Fortress. I opened this PR upstream to add Fortress support from source:

Once that's merged, we should be able to use the galactic branch here, as this PR is suggesting. We'll just need to also set GZ_VERSION=fortress next to IGNITION_VERSION in these places:

https://github.com/osrf/buoy_entrypoint/blob/f8cf6f312c4c5cf64d23ed73a149bb23ec1403ed/docker/buoy/Dockerfile#L11

https://github.com/osrf/buoy_entrypoint/blob/f8cf6f312c4c5cf64d23ed73a149bb23ec1403ed/README.md#L50

chapulina
chapulina suggested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after GZ_VERSION is added to the places suggested above.

@quarkytale
setting gz_version
26dac53 
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@chapulina chapulina merged commit 593d9b2 into main Jun 13, 2022
@chapulina chapulina deleted the quarkytale/rviz_support branch June 13, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@quarkytale quarkytale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quarkytale @chapulina