Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax spawn tight tolerance #66

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Relax spawn tight tolerance #66

merged 1 commit into from
Nov 5, 2021

Conversation

chapulina
Copy link
Contributor

I was too ambitious on #61, the current tight tolerance is flaky, see failure

2021-11-05T03:25:43.8355456Z 9: /home/developer/lrauv_ws/src/lrauv/lrauv_ignition_plugins/test/test_spawn.cc:161: Failure
2021-11-05T03:25:43.8356431Z 9: The difference between 0.0 and poses1.back().Pos().X() is 2.1789064913657771e-06, which exceeds tightTol, where
2021-11-05T03:25:43.8356995Z 9: 0.0 evaluates to 0,
2021-11-05T03:25:43.8357586Z 9: poses1.back().Pos().X() evaluates to -2.1789064913657771e-06, and
2021-11-05T03:25:43.8358198Z 9: tightTol evaluates to 9.9999999999999995e-07.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from tfoote November 5, 2021 03:33
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's pretty tight.

@chapulina chapulina merged commit 6a48e24 into main Nov 5, 2021
@chapulina chapulina deleted the chapulina/tight_tol branch November 5, 2021 17:37
@caguero caguero mentioned this pull request Nov 2, 2021
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants