-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Garden dependencies #128
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
All tests crashed on shutdown with "Child aborted". I can't reproduce it locally 🤔 |
Hmmm I'm able to reproduce the problems locally. I recommend running locally with |
Ah got it, let me try the nightlies, I was trying from source |
The CI failed with an odd failure:
|
I got a backtrace
The important detail there is |
The
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Alright, all we needed was an upgrade. It looks like we don't need to publish an updated MBARI image either. Although the controller is currently linking to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach is a bit fragile with caching on the Dockerfile. The upgrade will fail if the update hasn't been run recently. (ala cached) We should fold it into the chain of commands above installing ignition-garden instead of having it on it's own line.
Proposed fix #130 |
Thanks for the fix, @tfoote , merged it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ouch, that didn't work though |
@tfoote , any suggestion on the correct way of making sure these are upgraded as well?
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Kept the upgrade in the same |
Quick update since we have new dependencies on Garden. Note that
ign-math
,sdf
andign-physics
have also been bumped, so be sure to update your local workspaces.