Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BDOrthoIGN.geojson to exclude Channel Islands #2383

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

osmuser63783
Copy link
Contributor

This is my first time contributing here, I hope what I am doing is right.

The issue I am trying to fix is that the iD editor defaults to the BDOrtho IGN layer when editing in the Channel Islands, but this layer doesn't have any data in the Channel Islands, only in France. This has been reported before in #1260 and #2101.
Screenshot 2024-07-01 at 22 11 06

I opened https://github.com/osmlab/editor-layer-index/blob/gh-pages/sources/europe/fr/BDOrthoIGN.geojson in QGIS and subtracted the Channel Islands admin boundaries, which I got from OSM. The result is a polygon with 'holes' for the Channel Islands: https://github.com/osmuser63783/editor-layer-index/blob/db397a513e3fdf600ac92f47f4c8c88d6a4ab8e3/sources/europe/fr/BDOrthoIGN.geojson

Screenshot 2024-07-01 at 22 21 12

I haven't tested this on a test server with iD or anything like that. Please let me know if this should fix it!

@Intrinsica1
Copy link
Contributor

Intrinsica1 commented Jul 2, 2024

This adds a lot of unnecessarily precise geometry to roughly drawn bounds. I think the best thing here is to simply retrace the existing geometry. Or ideally obtain the actual bounds from IGN!

I have already started retracing a bit.

Decided to look into getting bounds directly instead.

I've found ORTHOIMAGERY.ORTHOPHOTOS.GRAPHE-MOSAIQUAGE:graphe_bdortho at https://data.geopf.fr/wfs/ows?SERVICE=WFS&VERSION=2.0.0&REQUEST=GetCapabilities

The issue is that it combines good bounds, with overly-complex internal geometry:
qgis-bin_nLxRxYRjAI

Dissolving it has been problematic.

@arch0345
Copy link
Contributor

I've simplified the geometry, inner rings aren't really needed to exclude these islands
image

@arch0345 arch0345 merged commit 46c6ead into osmlab:gh-pages Aug 18, 2024
1 check failed
@osmuser63783
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants