Update BDOrthoIGN.geojson to exclude Channel Islands #2383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing here, I hope what I am doing is right.
The issue I am trying to fix is that the iD editor defaults to the BDOrtho IGN layer when editing in the Channel Islands, but this layer doesn't have any data in the Channel Islands, only in France. This has been reported before in #1260 and #2101.
![Screenshot 2024-07-01 at 22 11 06](https://private-user-images.githubusercontent.com/127188803/344809522-794f8f20-41f9-44ed-9f48-a015daea64bd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyODE3NDIsIm5iZiI6MTcyNDI4MTQ0MiwicGF0aCI6Ii8xMjcxODg4MDMvMzQ0ODA5NTIyLTc5NGY4ZjIwLTQxZjktNDRlZC05ZjQ4LWEwMTVkYWVhNjRiZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyMVQyMzA0MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MmRkMDg2ZmMzOWYwOTdmMjQwODgxYjA4N2QwYTE1ZWU4OGVhNDQ0ZDJmYWUyMzEyNDFkZmU3MjQxNTQ2NDFlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.mJXIltcunNKiQpZht0z7eaPxH8NDJNiDx3yS_Ern9K8)
I opened https://github.com/osmlab/editor-layer-index/blob/gh-pages/sources/europe/fr/BDOrthoIGN.geojson in QGIS and subtracted the Channel Islands admin boundaries, which I got from OSM. The result is a polygon with 'holes' for the Channel Islands: https://github.com/osmuser63783/editor-layer-index/blob/db397a513e3fdf600ac92f47f4c8c88d6a4ab8e3/sources/europe/fr/BDOrthoIGN.geojson
I haven't tested this on a test server with iD or anything like that. Please let me know if this should fix it!