Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 3 Serbia layers #2301

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Adding 3 Serbia layers #2301

merged 1 commit into from
Aug 18, 2024

Conversation

stalker314314
Copy link
Contributor

There are 3 layers here that we think should be used:

  • Transparent layer that we use to import addresses and street on DINA (as per wiki page). This data is open and part of https://openstreetmap.org/copyright already. You can try this overlay here.
  • Raster layer based on Carto of official Serbia map. This is what we offer as community, per https://openstreetmap.rs/o-mapi/. Maps comes in two scripts (they are both official in Serbia) - cyrillic and latin. You can try both of them here. That practically means:
    • including Kosovo territory as part of Serbia,
    • making name:sr (or name:sr-Latn) as default label, and
    • removing Russian version of cyrillic italic font (Serbian and Russian italic differ)

I am only not sure what to put for "available_projections" (I omitted it) - one layer is based on maptiles vector server and other is mapnik/carto raster style.

@grischard
Copy link
Collaborator

@stalker314314 please see the CI log for fixes.

Since this index is for imagery for OpenStreetMap editors, and https://tiles.openstreetmap.rs/ shows OpenStreetMap data, I'm not sure that the layers are needed here. Definitely yes on the address layer.

Serbian and Russian italic differ

I didn't know that, interesting!

@stalker314314
Copy link
Contributor Author

Fixed CI errors, I hope. Regarding Serbian OSM rendering, I will let @pedjas reply. I sometimes use OSM as a layer in JOSM (it is convenient to locate yourself or find what you need visually), and this Serbian OSM rendering would serve same purpose, especially if you want to contribute in Kosovo (cultural heritage etc.), but Albanian is not your primary language and you can use this render to help yourself. Again - better to let @pedjas comment

@pedjas
Copy link

pedjas commented May 6, 2024

Since this index is for imagery for OpenStreetMap editors, and https://tiles.openstreetmap.rs/ shows OpenStreetMap data, I'm not sure that the layers are needed here. Definitely yes on the address layer.

https://tiles.openstreetmap.rs/ shows customized OSM data. It is not the same as OSM. It is bit adjusted to allow showing map tiles uniformly in Serbian language in both Serbian Cyrillic and Serbian Latin Scripts and some other content specific for mapping Serbia. For example: it gives priority to name:sr and name:sr-Latn tags instead of name tag.

It is intentionally rendered matching standard OSM tile style, but that is just a look, content differs. This is unique map we need as background for easier editing in Serbian language.

@stalker314314
Copy link
Contributor Author

@grischard Friendly ping:) I guess @pedjas provided explanation - this can be used as a QA tool to spot check where Serbian is missing (my interpretation). If you are still not in favor of it, please let us know!

@stalker314314
Copy link
Contributor Author

Another friendly ping!:)

@stalker314314
Copy link
Contributor Author

Another ping, @grischard . I see @arch0345 is also active, maybe they can chime in?

Copy link
Contributor

@arch0345 arch0345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, unfortunately I don't have write access so I can't merge this

@iandees iandees merged commit 1a7944d into osmlab:gh-pages Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants