-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NRW vDOP is blank while listed as best imagery for at least some areas #2273
Comments
See also #2262 |
It's been completely blank for weeks because all the imagery is now in the proper "NRW Orthophoto". They removed "done" areas from vDOP as they worked on them. Today it's even the default choice. "NRW Liegenschaftsregister" used to be the default but it loads really slowly, so that shouldn't be the first choice either. "NRW Orthophoto" should be top choice. It loads quickly and it's up to date. I wish iD would remember my choices and other settings across sessions... Unless someone else is working on it, I'll swap the |
resolves osmlab#2262 resolves osmlab#2273
Offtopic:
FYI: If you use the stand alone version from the readme in GitHub you get proper url parses that store the selected imagery. You can then bookmark that. |
Thank you for that hint. I gather that involves running it locally. I might try that. I'm already redirecting tile requests through a local nginx because the NRW WMS tells clients to not cache at all, which I find silly... i.e. I'm already somewhat into running things locally. I just noticed that this issue here might have been created with the intention of perhaps removing the vDOP entry. I have no strong feelings on that either way. |
No, you can use https://ideditor-release.netlify.app/#background=nrw_ortho_wms&disable_features=boundaries&map=18.14/50.77696/6.08326 (from https://github.com/openstreetmap/id?tab=readme-ov-file#participate) |
Back to the issue at hand: I think @pathmapper it would be best if you took over here since you introduced the data in #2022. We have a few things fix here, IMO
I did no research in this area other than scanning the comments in #2022 (comment) and similar issues. But I think we have to improve the situation soon by…
Given those constrains, what would you say is the best way forward, @pathmapper |
I don't have much to add to #2022 (comment): It all depends on how best is definied, and IMHO there is currently no such clear definition. So this should be resolved. I always understood best as most recent available data, because currentness of data is crucial if one wants to trace things for OSM.
The area is changing constantly, e.g. for
Do we really need to pick a "best" layer? For NRW we are having three different aerial sources, and it's constantly changing which source of them is the most recent for a given area. Given the lack of a clear definition for what is "best", I currently won't assign "best" to any of the three sources. |
I think that casual users, entering the editor, should never be faced with a blank background layer. That is just a bad user experience. And it's annoying to everyone using the editor. Those vDOP and iDOP layers are "incomplete" and constantly changing. Even worse, the vDOP layer "lost" content over time (as it was done processing and incorporated into "NRW Orthophoto", the normal DOP), so if one saw imagery with the default behavior yesterday, and then opened the editor again today, and it was blank where it showed something yesterday, that is utterly bewildering. Those should definitely not be the default picks. They should remain though, with a description of what to expect of those layers, and what not to expect. One could also "advertise" those layers in the description of the regular "NRW Orthophoto". I did not expect my PR to be considered controversial. |
What happens if none of the NRW sources are tagged as "best"? If there are no other "best" sources, we'd get Bing Maps because it's alphabetically the first. If there are other "best" sources, as happens near the borders and sometimes a sizable distance "inland", then those take precedence, but they're blank in NRW. A simple and generally beneficial change is to "tolerate" |
True, that's also not nice. But at least there's no layer advertised as I don't have a strong opinion here, go with Just keep in mind that it's expecteded that Also new I really do like the comment from #130 (comment):
So it's time for something new, looks like #130 is a good place for anyone who has some suggestions to join the discussion. |
Resolution also matters (extreme example: daily updated satellite imagery with resolution of 100m is worse than aerial with resolution of 1cm updated 6 months ago). Quality of georeferencing, colours, when it was taken (leafless imagery) may also matter. |
https://www.openstreetmap.org/edit?editor=id#map=19/51.18137/7.17874
The text was updated successfully, but these errors were encountered: