Add unit tests #594
Merged
Add unit tests #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic usage instructions to the readme, including about configuring the language. Formatted the acknowledgements as Markdown and added the mapbox-gl-rtl-text plugin. Mentioned unit tests in the contributing guide.
This was referenced Dec 1, 2022
jleedev
reviewed
Dec 2, 2022
1ec5
commented
Dec 2, 2022
| "create-serve": "^1.0.1", | ||
| "esbuild": "^0.15.15", | ||
| "maplibre-gl": "^2.1.9", | ||
| "mocha": "^10.1.0", |
There was a problem hiding this comment.
I got some valuable feedback on Slack that Mocha/Chai is outmoded and Jest would be more fashionable. However, with the recently released Node 19 including a first-party test runner out of the box, it’s only a matter of time before we switch to that instead, given our very lightweight testing needs. For the time being, I’d like to unblock #592 while respecting this project’s support for Node LTS, so I’ll keep this choice of dependencies for now, with an eye towards rewriting the unit tests once we make a decision to drop Node 18 support.
jleedev
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installed Mocha and Chai as development dependencies so that we can write unit tests for parts of this application that can run independently of a browser. Unit tests run as a continuous integration check, or you can run them manually using
npm test. As a starting point, I added tests of a trivial URL parsing function from #581, but more will come as part of #592.Updated various documentation to reflect the current state of the deployed map.