Localize labels dynamically #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layer count was misleadingly logged any time an image loaded.
This was referenced Nov 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of the hash at the end of the application’s URL has changed from
#zoom/latitude/longitudeto#map=zoom/latitude/longitude, which is consistent with both openstreetmap.org and iD. For easier map sharing and debugging, the application now accepts alanguage=parameter as part of the hash. For example,#map=12/29.95/-90.08zooms to New Orleans, but#language=fr&map=12/29.95/-90.08zooms to La Nouvelle Orléans, and#language=vi,es&map=12/29.95/-90.08zooms to Nueva Orleans.The application is now capable of rebuilding the entire style at an arbitrary time after the page loads. It rebuilds the style any time the user’s language preference changes or the URL hash’s
languageparameter changes. The only dynamic part of the style is label localization. Rebuilding the layers is challenging because of the codebase’s extensive use of global variables, but this PR uses ametadatafield to persist an indication of the intention to localize a given layer’stext-fieldproperty, which is resolved just before setting the style.Fixes #20 and fixes #579.