Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Selma to Montgomery National Historic Trail shield #1116

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Add Selma to Montgomery National Historic Trail shield #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51ccbb0
Add Selma to Montgomery National Historic Trail shield
quincylvania Jun 30, 2024
dde5dde
Add black outline to shield
quincylvania Jul 2, 2024
4e4d997
Merge branch 'main' into semo
ZeLonewolf Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions icons/shield_us_nht_semo.svg
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sky blue surrounded by white doesn’t have very much contrast against an already light background. Should we surround all that with another black outline, or would that be too heavy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does look better, though is the shield getting too large now? We should probably have consistency across all the National Historic Trail shields (and look forward to National Scenic Trail shields, which are similar in design).

Screenshot 2024-07-01 at 10 28 11 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is 22x21. The above is 24x23.

Screenshot 2024-07-01 at 11 07 40 AM

Copy link
Member

@1ec5 1ec5 Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives the shield more definition, which is great. I agree that it should be consistent with the other Reuleaux triangles.

As an aside, maybe we should consider putting an extra outline around anything we’re currently outlining in white, including the Interstate shield. Apple Maps takes this approach; sometimes it makes the shields look more cartoonish, but the added contrast really comes in handy over light backgrounds.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions src/js/shield_defs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,15 @@ export function loadShields() {
},
};

shields["US:NHT"] = {
notext: true,
overrideByName: {
"Selma to Montgomery National Historic Trail": {
spriteBlank: "shield_us_nht_semo",
},
},
};

// Other multistate routes

// Great Lakes Seaway Trail
Expand Down
Loading