Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Selma to Montgomery National Historic Trail shield #1116

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

quincylvania
Copy link
Contributor

This one is a little different: since the historic trail consists pretty much of extant roads, there's no "auto tour route" separate from the trail.

https://www.openstreetmap.org/relation/13302056

https://commons.wikimedia.org/wiki/File:45th_Anniversary_of_the_Civil_Rights_March_from_Selma,_Alabama_to_Montgomery,_Alabama_LCCN2010637779.tif

Re: #1101

Screenshot 2024-06-30 at 11 38 17 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sky blue surrounded by white doesn’t have very much contrast against an already light background. Should we surround all that with another black outline, or would that be too heavy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does look better, though is the shield getting too large now? We should probably have consistency across all the National Historic Trail shields (and look forward to National Scenic Trail shields, which are similar in design).

Screenshot 2024-07-01 at 10 28 11 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is 22x21. The above is 24x23.

Screenshot 2024-07-01 at 11 07 40 AM

Copy link
Member

@1ec5 1ec5 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives the shield more definition, which is great. I agree that it should be consistent with the other Reuleaux triangles.

As an aside, maybe we should consider putting an extra outline around anything we’re currently outlining in white, including the Interstate shield. Apple Maps takes this approach; sometimes it makes the shields look more cartoonish, but the added contrast really comes in handy over light backgrounds.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants