Sneaky signed ± anti-overflow

[oscbyspro]

The current addition and subtraction methods have this structure:

@inlinable public mutating func addReportingOverflow(_ other: Self) -> Bool {
    let a: Bool = self.low .addReportingOverflow(other.low )
    let b: Bool = self.high.addReportingOverflow(other.high)
    let c: Bool = a && self.high.addReportingOverflow(1 as Digit)
    return b || c // this should be « b != c » (!)
}

The problem is that b and c negate each other when signed. See tests below:

NBKAssertAddition   (T(descending: HL(.max, .max)), T(-1), T(descending: HL(.max, .max - 1)), false) // carry 1st
NBKAssertAddition   (T(descending: HL(.min, .max)), T(-1), T(descending: HL(.min, .max - 1)), false) // carry 2nd

NBKAssertSubtraction(T(descending: HL(.min, .min)), T(-1), T(descending: HL(.min, .min + 1)), false) // carry 1st
NBKAssertSubtraction(T(descending: HL(.max, .min)), T(-1), T(descending: HL(.max, .min + 1)), false) // carry 2nd

These tests validate the case where b appears before c and vice versa.

[oscbyspro]

Perhaps it's worth noting that b and c cannot be true at the same time if the integer is unsigned for the same reason that max + max + 1 < (high: 2, low: 0).