Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant type aliases #126

Closed
oscbyspro opened this issue Jun 10, 2023 · 2 comments
Closed

Remove redundant type aliases #126

oscbyspro opened this issue Jun 10, 2023 · 2 comments
Labels
subtraction huh? where did it go?
Milestone
v3.0.0

Comments

@oscbyspro
Copy link
Owner

oscbyspro commented Jun 10, 2023 •
edited

I don't quite see the point in having both Int256 and ANKInt256, or Signed and ANKSigned, for example.
@oscbyspro oscbyspro added the subtraction huh? where did it go? label Jun 10, 2023
@oscbyspro oscbyspro added this to the v3.0.0 milestone Jun 10, 2023
@oscbyspro oscbyspro changed the title Remove prefixed type aliases Remove redundant type aliases Jun 10, 2023
oscbyspro added a commit that referenced this issue Jun 10, 2023
@oscbyspro
removed redundant type aliases (#126)
1506ebc
@oscbyspro
Copy link
Owner Author

oscbyspro commented Jun 10, 2023 •
edited

Model names were kept as is, meaning with ANK prefix, but type aliases like Int256 were kept without prefix.

@oscbyspro
Copy link
Owner Author

oscbyspro commented Jun 10, 2023 •
edited

ANKInt64 and ANKUInt64 were moved to the ANK namespace because they are conditionally compiled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
subtraction huh? where did it go?
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@oscbyspro