Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No matches(repeating:) and isFull #123

Closed
oscbyspro opened this issue Jun 9, 2023 · 1 comment
Closed

No matches(repeating:) and isFull #123

oscbyspro opened this issue Jun 9, 2023 · 1 comment
Labels
subtraction huh? where did it go?
Milestone
v3.0.0

Comments

@oscbyspro
Copy link
Owner

From oscbyspro/Numberick#5

After some refactoring, matches(repeating:) and isFull are no longer used anywhere. While I like the idea of them, I'll remove them in service of pragmatism. For reference, both are members of NBKFixedWidthInteger.
@oscbyspro oscbyspro added the subtraction huh? where did it go? label Jun 9, 2023
@oscbyspro oscbyspro added this to the v3.0.0 milestone Jun 9, 2023
@oscbyspro
Copy link
Owner Author

oscbyspro commented Jun 9, 2023 •
edited

This requires (#122) and (#121) because isFull is still used in multipliedReportingOverflow(by:).

oscbyspro added a commit that referenced this issue Jun 11, 2023
@oscbyspro
NBK-esque rework (#121) (#122) (#123) (#127) (#128) (#129) (#132)
f13acf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
subtraction huh? where did it go?
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@oscbyspro