mockbuild: make more consistent with other osbuild projects #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These logs are not preserved, just remove them.
Change the repository path on S3 to a more predictable one, mirroring the pattern we're using for osbuild-composer. Notably, don't use short commit ids. The length of these is not predictable. It depends on the shortest unique prefix in the repository and git configuration. For example, koji-osbuild commit $SHA for fedora-33 on x86_64 will result in this URL: koji-osbuild/fedora-33/x86_64/$SHA
Repository URLs are predictable. There's no need to use Jenkins' stash feature to pass the repo file between stages. Instead, simply create the repo file where it is needed, in deploy.sh.
This avoids doing unnecessary work and speeds up restarting tests.
These don't need to run when we're not building anything.
Remove koji-osbuild.spec.in and the bits in meson.build that generate the final spec file out of it. Pull in the changelog from how Ondřej Budai does it in osbuild-composer, because it's adorable. When releasing, the version now has to be bumped in the spec file. This is to make it consistent with other osbuild projects, and to simplify reverse dependency testing.
Running `meson build` on the host can have different results from building the SRPM in mock.
larskarlitski
force-pushed
the
mockbuild
branch
from
943c97b
to
160b755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these commits come from similar ones on osbuild-composer, only amended for the use of
mesonhere. Please see individual commits.