Hub: support image_type being an array for backwards compatibility
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
force-pushed
the
image-types-array-compat
branch
3 times, most recently
from
f9fb404
to
16a7efd
Compare
ondrejbudai
requested changes
Sep 2, 2022
thozza
force-pushed
the
image-types-array-compat
branch
2 times, most recently
from
6b7a22c
to
1a60801
Compare
The support for specifying multiple `image_types` for a single compose has been removed by [1]. This turned out to be problematic, because e.g. Pungi uses the array type when triggering image builds via osbuild. Bring back the support for specifying the `image_type` as an array, but restrict it to a single item. This will cover the Pungi use-case, since it is always passing a single `image_type` in the array. The array is then converted to a string in the Hub plugin and passed as such to the Builder plugin. Extend unit tests covering the introduced compatibility layer. [1] osbuild@c725265
thozza
force-pushed
the
image-types-array-compat
branch
from
1a60801
to
715a1d1
Compare
ondrejbudai
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for specifying multiple
image_typesfor a single composehas been removed by [1]. This turned out to be problematic, because e.g.
Pungi uses the array type when triggering image builds via osbuild.
Bring back the support for specifying the
image_typeas an array, butrestrict it to a single item. This will cover the Pungi use-case, since
it is always passing a single
image_typein the array. The array isthen converted to a string in the Hub plugin and passed as such to the
Builder plugin.
Extend unit tests covering the introduced compatibility layer.
[1] c725265