Various enhancements #105
Merged
Various enhancements #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest osbuild and osbuild-composer releases. This is important to be later able to test direct uploading to the cloud for Koji composes. Also the mock openid server had to be enhanced to be usable for testing `koji-osbuild`. Modify used osbuild-worker configuration to use JWT for authentication with composer. Update configurations of both, composer and worker to handle multi-tenancy. Do not start any services in `schutzbot/deploy.sh`, because at that point, none of the configuration files are in place. Ensure that the correct units are started and masked by `test/integration.sh` to simulate the Service scenario more closely. This means that the local worker is masked and only remote worker is started. Co-authored-by: Jakub Rusz <jrusz@redhat.com>
Refactor the test case implementation to make it easier to reuse existing code when adding a new testing scenario. The common pieces were moved under a new `SutInfo` class, which provides information and convenience methods related to the system on which the test is running. This change will make it easier to later add a new scenario testing upload to the cloud.
Previously, the image status in the compose status uploaded to the koji build was represented as a single string describing the overall status. All information related to the image upload or error details were thrown away. Refactor `ImageStatus` to contain all the information about the image, its upload targets and potential errors, as they are returned by composer. This will improve the experience when debugging compose failures. In addition, including all the data will be important once images will be uploaded directly to the cloud, because it will contain information to locate the image in the cloud environment.
While it is technically possible to build more than one image type as part of a Koji compose in osbuild-composer, this option is not used in reality and it also makes very little sense. If the user wants to build more than one image type, they should submit multiple Koji builds. Adjust affected unit tests.
Spell check started to freak out on `complies` in the `LICENSE`. Exclude `LICENSE` from spell check until it learns English.
thozza
requested review from
gicmo,
ondrejbudai and
jrusz
and removed request for
gicmo,
ondrejbudai and
jrusz
jrusz
reviewed
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked commits from #104, on which there is consensus.
Notable changes
osbuildandosbuild-composerversions used in CI to more recent ones. Adjust the relevant configuration files to reflect changes done to how JWT is configured.compose_status.json.