Add support for gcp uploads #1744
Conversation
jkozol
force-pushed
the
gcp
branch
6 times, most recently
from
069f152
to
9d11fc3
Compare
There was a problem hiding this comment.
Thanks a lot for implementing the support for GCE images!
Looks good from my PoV to the extent to which I can read JavaScript 😅
I think that the object does not need to be provided by the user. My bad, I should have updated the guides... Alternatively it can be made optional, instead of being completely removed...
One additional comment WRT the credentials file, which may be good to discuss with UX. My hope was that the user would just provide credentials as downloaded from GCP in the JSON format and cockpit-composer would encode the content of the file as Base64 before calling Weldr API. I think that it would simplify the user experience by not requiring the user to do additional step (encoding the file in base64). Now it looks as if the user has to first download JSON file with credentials from GCP, encode the file content in base64 and save it as a file and lastly upload that encoded file to cockpit-composer.
|
@thozza Cockpit composer now expects the plain json file and will encode it before passing to osbuild-composer. |
The firewall configuration now defaults to an empty object. This prevents old blueprints from erroring when they have no firewall declared.
jkozol
force-pushed
the
gcp
branch
4 times, most recently
from
03e5bba
to
9368954
Compare
GCE images can now be created and uploaded to gcp. This adds new upload fields for the Storage region, Bucket, Object key, and Credentials. The credentials should be a file upload. This is all only on RHEL.
No description provided.