[test] Skip chunked_binary_trees tests on slower configurations.

Bug: dart-lang#52924 Change-Id: Iece24184411f1fdbc63903d893654c74aed3de55 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313289 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
osa1 · Jul 17, 2023 · 979adb2 · 979adb2
1 parent b510fcb
commit 979adb2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/runtime/tests/vm/dart/gc/chunked_binary_trees_array_test.dart b/runtime/tests/vm/dart/gc/chunked_binary_trees_array_test.dart
@@ -9,6 +9,10 @@
 // VMOptions=--no_eliminate_write_barriers
 // VMOptions=--no_inline_alloc
 
+// Stress test for write barrier elimination that leaves many stores with
+// eliminated barriers that create the only reference to an object in flight at
+// the same time.
+
 buildTopDown(List n, int depth) {
   if (depth == 0) return;
 

diff --git a/runtime/tests/vm/dart/gc/chunked_binary_trees_test.dart b/runtime/tests/vm/dart/gc/chunked_binary_trees_test.dart
@@ -9,6 +9,10 @@
 // VMOptions=--no_eliminate_write_barriers
 // VMOptions=--no_inline_alloc
 
+// Stress test for write barrier elimination that leaves many stores with
+// eliminated barriers that create the only reference to an object in flight at
+// the same time.
+
 class Node {
   Node? left, right;
   int depth;

diff --git a/runtime/tests/vm/vm.status b/runtime/tests/vm/vm.status
@@ -173,6 +173,8 @@ dart_2/transferable_throws_oom_test: SkipByDesign # This test tries to allocate
 [ $sanitizer == tsan ]
 dart/analyze_snapshot_binary_test: SkipSlow
 dart/appjit_cha_deopt_test: SkipSlow
+dart/gc/chunked_binary_trees_array_test: SkipSlow
+dart/gc/chunked_binary_trees_test: SkipSlow
 dart/gc/fragmentation*: Skip # Uses too much memory with TSAN overhead and kills bot
 dart/gc/out_of_memory*: Skip # Uses too much memory with TSAN overhead and kills bot
 dart/gc/scavenger_abort_test: SkipSlow
@@ -199,6 +201,8 @@ dart_2/v8_snapshot_profile_writer_test: SkipSlow
 dart_2/weak_canonical_string_table_test: Pass, Slow # This test can take a longer time to complete.
 
 [ $system == android ]
+dart/gc/chunked_binary_trees_array_test: SkipSlow
+dart/gc/chunked_binary_trees_test: SkipSlow
 dart/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # On android this test does not work due to not being able to identify library uri.
 dart/sdk_hash_test: SkipByDesign # The test doesn't know location of cross-platform gen_snapshot
 dart_2/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # On android this test does not work due to not being able to identify library uri.
@@ -264,6 +268,8 @@ cc/Profiler_ToggleRecordAllocation: SkipByDesign
 cc/Profiler_TrivialRecordAllocation: SkipByDesign
 cc/Profiler_TypedArrayAllocation: SkipByDesign
 cc/Service_Profile: SkipByDesign
+dart/gc/chunked_binary_trees_array_test: SkipSlow
+dart/gc/chunked_binary_trees_test: SkipSlow
 dart/gc/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
 dart/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
 dart/isolates/thread_pool_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
@@ -510,6 +516,8 @@ dart_2/thread_priority_windows_test: SkipByDesign
 [ $hot_reload || $hot_reload_rollback ]
 dart/appjit*: SkipByDesign # Cannot reload with URI pointing to app snapshot.
 dart/disassemble_determinism_test: SkipSlow # Runs expensive fibonacci(32) computation in 2 subprocesses
+dart/gc/chunked_binary_trees_array_test: SkipSlow
+dart/gc/chunked_binary_trees_test: SkipSlow
 dart/issue_31959_31960_test: SkipSlow
 dart/minimal_kernel_test: SkipSlow # gen_kernel is too slow in hot reload testing mode
 dart/null_safety_autodetection_in_kernel_compiler_test: SkipSlow # gen_kernel is too slow in hot reload testing mode