Skip to content

Commit

Permalink
fix: bump golangci-lint
Browse files Browse the repository at this point in the history
  • Loading branch information
alnr committed Aug 6, 2024
1 parent a94ab2b commit 8049ccf
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.55.2
version: v1.59.1
skip-go-installation: true
args: --timeout 5m
- name: Install cockroach DB
Expand Down
3 changes: 1 addition & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
linters:
enable:
- gosec
- vet
- govet
disable-all: true

run:
skip-files:
- "migrate_files.go" # go-bindata
- ".+_test.go"
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ licenses: .bin/licenses node_modules # checks open-source licenses
GOBIN=$(shell pwd)/.bin go install golang.org/x/tools/cmd/goimports@latest

.bin/golangci-lint: Makefile
curl -sSfL https://github.com/raw/golangci/golangci-lint/master/install.sh | sh -s -- -b .bin v1.55.2
curl -sSfL https://github.com/raw/golangci/golangci-lint/master/install.sh | sh -s -- -b .bin v1.59.1

.bin/licenses: Makefile
curl https://github.com/raw/ory/ci/master/licenses/install | sh
Expand Down
3 changes: 1 addition & 2 deletions cmdx/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,8 @@ func NewClient(cmd *cobra.Command) (*http.Client, *url.URL, error) {

rt := httpx.NewTransportWithHeader(header)
rt.RoundTripper = &http.Transport{
//#nosec G402 -- This is a false positive
TLSClientConfig: &tls.Config{
InsecureSkipVerify: skipVerify,
InsecureSkipVerify: skipVerify, //nolint:gosec // This is a false positive
},
}
hc.Transport = rt
Expand Down
3 changes: 1 addition & 2 deletions httpx/gzip_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ func (c *CompressionRequestReader) ServeHTTP(w http.ResponseWriter, r *http.Requ
return
}

/* #nosec G110 - FIXME */
if _, err := io.Copy(&b, reader); err != nil {
if _, err := io.Copy(&b, reader); err != nil { //nolint:gosec // FIXME
c.ErrHandler(w, r, err)
return
}
Expand Down

0 comments on commit 8049ccf

Please sign in to comment.