[WIP] Add Update #109
Open
[WIP] Add Update #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afflom
changed the title
jpower432
reviewed
Oct 18, 2022
| collectionManifestAnnotations := map[string]string{} | ||
| var descs []ocispec.Descriptor | ||
|
|
||
| if config.Collection.SchemaAddress != "" { |
There was a problem hiding this comment.
Is this section any different from the schema validation in the Build method?
jpower432
reviewed
Oct 18, 2022
| func (d DefaultManager) Update(ctx context.Context, space workspace.Workspace, src string, dest string, add bool, remove bool, client registryclient.Client) (string, error) { | ||
|
|
||
| // Pull the dataset config from the target collection | ||
| _, manBytes, err := client.GetManifest(ctx, src) |
There was a problem hiding this comment.
I wonder if this type of action could benefit from a dry run or if it could just construct the workspace and pass it to the top-level Build method. Just so the user can validate the workspace before any references are overwritten.
jpower432
reviewed
Oct 18, 2022
| } | ||
|
|
||
| if remove { | ||
| pruneDescs, err := d.pullCollection(ctx, src, memory.New(), client) |
There was a problem hiding this comment.
Depending on what files are being deleted, this action could run the system out of memory since this is storing all of the files as byte slices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.