Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] absolute paths stored as artifact annotation create unexpected pulling behavior #10

Closed
jpower432 opened this issue May 16, 2022 · 0 comments · Fixed by #19
Closed

[BUG] absolute paths stored as artifact annotation create unexpected pulling behavior #10

jpower432 opened this issue May 16, 2022 · 0 comments · Fixed by #19
Assignees
@afflom
Labels
bug Something isn't working

Comments

@jpower432
Copy link
Contributor

What happened?

When using oras CLI to retrieve an artifact published by the client, all files are written to the absolute path where they were original published from.

What behavior was expected?

The artifacts to be copied to the current directory (or directory specified) when copying.
@jpower432 jpower432 added the bug Something isn't working label May 16, 2022
@afflom afflom self-assigned this May 24, 2022
afflom added a commit to afflom/client that referenced this issue May 25, 2022
@afflom
Use relative paths for blob titles(ortelius#10)
6aa00a1
@afflom afflom mentioned this issue May 25, 2022
Closed
jpower432 added a commit to jpower432/client that referenced this issue May 25, 2022
@jpower432
fix(cli): changes file paths to relative paths for the registry client
1f60ef3 
Since the build path is in a disposable directory, it cannot be included
in the "title" annotation on the artifacts. To fix this, relative paths within
the workspace are passed to the oras client and the directory is changed before
processing.

Closes ortelius#10

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 mentioned this issue May 25, 2022
Merged
jpower432 added a commit to jpower432/client that referenced this issue May 26, 2022
@jpower432
fix(cli): changes file paths to relative paths for the registry client
403b54c 
Since the build path is in a disposable directory, it cannot be included
in the "title" annotation on the artifacts. To fix this, relative paths within
the workspace are passed to the oras client and the directory is changed before
processing.

Closes ortelius#10

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432 added a commit to jpower432/client that referenced this issue Jun 1, 2022
@jpower432
fix(cli): changes file paths to relative paths for the registry client
0413080 
Since the build path is in a disposable directory, it cannot be included
in the "title" annotation on the artifacts. To fix this, relative paths within
the workspace are passed to the oras client and the directory is changed before
processing.

Closes ortelius#10

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@afflom afflom closed this as completed in #19 Jun 2, 2022
jpower432 added a commit to jpower432/client that referenced this issue Jun 21, 2022
@jpower432
fix(cli): changes file paths to relative paths for the registry client
e370ae5 
Since the build path is in a disposable directory, it cannot be included
in the "title" annotation on the artifacts. To fix this, relative paths within
the workspace are passed to the oras client and the directory is changed before
processing.

Closes ortelius#10

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afflom afflom

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@afflom @jpower432