Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: expose layertype #2032

Closed
wants to merge 5 commits into from
Closed

feature: expose layertype #2032

wants to merge 5 commits into from

Conversation

johnnyblasta
Copy link
Collaborator

Closes #2031

@Grammostola
Copy link
Contributor

Grammostola commented Jul 30, 2024

mulfvik wrote in the related issue:

Tested this and it seems, due to that Origo loads config before plugin(?), that it would take some promiseAll operation to load them when them all is finished.

A plugin may bring support for a new layer type

Is what you wrote in the issue as a reason for exposing Layertype.

I at least agree that the purpose appears somewhat opaque. Is it to be able to add a layer type to Origo so that all parts of it and potentially other plugins can use the new layer type? (There would seem to be parts missing if that's the case like a method to add layerTypes). As mulfvik deduces the plugins are loaded after Origo so Origo wouldn't be able to use the new type during init. This all makes me think this is not your indended scenario.

Or is it to access Origo's existing layer type definitions in case a plugin wants to do something with them, possibly extend one?

@johnnyblasta
Copy link
Collaborator Author

If the order of loading of types isn't resolved somehow, the purpose of this PR does not resolve the intended issue.

@johnnyblasta
Copy link
Collaborator Author

Closing this since it won't work for intended purpose for plugins.
To be able to add layers type is still something that might be useful, but has to be reworked a bit to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose layertype
2 participants