-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimize button to infowindow #2030
base: master
Are you sure you want to change the base?
Conversation
Added .minimizebutton-svg-container
Added minimize button
You can read about tabindex here but 0 is a good value here. Negative value means the button cannot be focused on. |
I can't reproduce, but it was probably caused by a mix of px/em/rem in padding/margin. Can you check if I managed to fix it? |
Looks better now. But I noticed something else. If you:
...you will notice that the infowindow opens in minimized mode. I don't think this should be the default behavior. |
Fix so that infowindow doesn't remain minimized after clicking the close button.
I've fixed so infowindow doesn't remained minimized after clicking close. |
Why is the icon different compared to the popup in #1949 |
I created a minimize button for the infowindow (like I've previously did for the popup #1949).
I'm not sure if or how the tabindex should be changed though.