Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimize button to infowindow #2030

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

huggla
Copy link
Contributor

@huggla huggla commented Jun 25, 2024

I created a minimize button for the infowindow (like I've previously did for the popup #1949).

image

I'm not sure if or how the tabindex should be changed though.
image

@johnnyblasta
Copy link
Collaborator

You can read about tabindex here but 0 is a good value here. Negative value means the button cannot be focused on.

@tonnyandersson
Copy link
Collaborator

Seems to minimize a little too much, resulting in button covering text.

image

@huggla
Copy link
Contributor Author

huggla commented Jul 2, 2024

I can't reproduce, but it was probably caused by a mix of px/em/rem in padding/margin. Can you check if I managed to fix it?

@tonnyandersson
Copy link
Collaborator

Looks better now. But I noticed something else. If you:

  1. Click on an object to open the infowindow
  2. Minimize the infowindow
  3. Close the infowindow
  4. Click on a new object to open the infowindow

...you will notice that the infowindow opens in minimized mode. I don't think this should be the default behavior.

minimize

Fix so that infowindow doesn't remain minimized after clicking the close button.
@huggla
Copy link
Contributor Author

huggla commented Aug 13, 2024

I've fixed so infowindow doesn't remained minimized after clicking close.

@johnnyblasta
Copy link
Collaborator

Why is the icon different compared to the popup in #1949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants