Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rust and github actions dependencies #110

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

woshilapin
Copy link
Contributor

Description

Update dependencies (Rust and Github Actions).

Motivation and Context

#108

How Has This Been Tested?

No change of functionality so I just checked that existing tests still passed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other : update dependencies

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation and changelog accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Rustfmt and Rust-clippy passed.

@orhun
Copy link
Owner

orhun commented Oct 20, 2023

There seems to be a couple of CI failures, can you look into them please?

'anstream:0.6.4' has a minimal requirement for 'rustc:1.70.0'.
@woshilapin
Copy link
Contributor Author

There seems to be a couple of CI failures, can you look into them please?

@orhun There is different kind of errors.

First, Rust had new versions since last time the CI ran. Therefore, new clippy lints makes the CI fails. I've addressed these problems in a different PR since it's unrelated to the bump of dependencies' version (see #111). This other PR must be addressed first.

Secondly, when updating the different versions, anstream has been bumped to 0.6.4 which is not support below rustc:1.70.0. Therefore, I've bumped the minimal version of rustc in the Dockerfile (see 3aba718).

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐻

@orhun orhun merged commit bf820e8 into orhun:master Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants