Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /runes/balances API endpoint #3980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lifofifoX
Copy link
Collaborator

This endpoint returns every output containing any kind of a Rune. That doesn't seem very useful, and it's potentially a DDoS vector.

This endpoint returns every output containing any kind of a Rune. That doesn't seem very useful, and it's potentially a DDoS vector.
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was only active if the JSON API is enabled, but you're probably right. Makes sense to remove it. LGTM

@casey what do you think?

@casey
Copy link
Collaborator

casey commented Oct 4, 2024

I'm fine with removing it, it's kind of a nutty endpoint. If someone complains that it's gone, we can always add it back.

@lifofifoX
Copy link
Collaborator Author

I recently setup a cluster of ord nodes with all indexes and API enabled. So, DDoS is my main concern. Not sure how founded in reality is that, but I am guessing it won't take too many requests to this endpoint to bring it to a halt.

In practice, I've used hardcoded rune name in this API endpoint on my local node to take snapshots. So, if we bring it back, maybe that's a more realistic use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants