Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix #1682

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Typo fix #1682

merged 1 commit into from
Feb 13, 2023

Conversation

sbddesign
Copy link
Contributor

Fixed typo "use maintain"

Copy link
Contributor

@Psifour Psifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar still feels awkward. Maybe something more in-line with "Transaction Index support must be enabled in Bitcoin Core by adding the following to your bitcoin.conf"

@sbddesign
Copy link
Contributor Author

I disagree. Your proposal puts the sentence into passive voice, which appears to contradict the way the other sentences are written (at a cursory glance).

@Psifour
Copy link
Contributor

Psifour commented Feb 12, 2023

That is an acceptable opinion.
I can fully agree that the "use" was grammatically incorrect.

ACK 55f838545349db965490a74fdeb59b14dd73f2f6

@casey casey enabled auto-merge (squash) February 13, 2023 03:16
@casey casey disabled auto-merge February 13, 2023 03:16
@casey casey enabled auto-merge (squash) February 13, 2023 03:16
@casey casey disabled auto-merge February 13, 2023 03:17
@casey casey enabled auto-merge (squash) February 13, 2023 03:17
@casey casey disabled auto-merge February 13, 2023 03:17
@casey
Copy link
Collaborator

casey commented Feb 13, 2023

Discussion and an ack on a typo fix, making my life as a maintainer so easy❤️

Tried to merge, but phone UI is terrible, will merge later.

In general, anything that is a pareto improvement can be insta-merged, and feedback/improvements can be deferred to a follow-up issue. A typo or grammar fix is almost always a Pareto improvement.

Open PRs are my highest priority queue items, so I always want to merge, convert to draft, or close, to keep things moving.

Fixed typo "use maintain"
@raphjaph raphjaph enabled auto-merge (squash) February 13, 2023 20:29
@raphjaph raphjaph merged commit 27d8d18 into ordinals:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants