-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory Support #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolitsky
reviewed
Apr 11, 2019
jdolitsky
reviewed
Apr 11, 2019
/test |
jdolitsky
approved these changes
Apr 11, 2019
yuwaMSFT2
reviewed
Apr 11, 2019
yuwaMSFT2
reviewed
Apr 11, 2019
yuwaMSFT2
reviewed
Apr 11, 2019
/test |
jdolitsky
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
oras
to push / pull a directory to / from a remote registry.To push, the target directory is compressed into a
tar.gz
temproray file (on Linux, it sits at/tmp
). Then thetar.gz
file is pushed normally with media typeapplication/vnd.oci.image.layer.v1.tar+gzip
and extra annotationsio.deis.oras.content.digest
: thesha256
digest of the internaltar
file. It is different from the digest of thetar.gz
file.io.deis.oras.content.unpack
: marked astrue
for extration when pull.To pull, the
tar.gz
file is pulled to a temprorary directory. Then it is extracted and verified againstio.deis.oras.content.digest
.Notes:
defer store.Close()
for*FileStore
to release resources.Resolves #54