Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: push an ORAS artifact manifest when no blob is specified #486

Closed
wants to merge 3 commits into from

Conversation

yuehaoliang
Copy link
Contributor

Resolve #466

Signed-off-by: Haoliang Yue yuehaoliang@microsoft.com

Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
cmd/oras/push.go Show resolved Hide resolved
cmd/oras/push.go Outdated Show resolved Hide resolved
Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
@yuehaoliang yuehaoliang changed the title pushing an ORAS artifact manifest when no blob is specified feat: pushing an ORAS artifact manifest when no blob is specified Aug 10, 2022
@yuehaoliang yuehaoliang changed the title feat: pushing an ORAS artifact manifest when no blob is specified feat: push an ORAS artifact manifest when no blob is specified Aug 10, 2022
cmd/oras/push.go Outdated Show resolved Hide resolved
Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #486 (7ce7ec7) into main (d776a22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files           6        6           
  Lines         237      237           
=======================================
  Hits          132      132           
  Misses         90       90           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sajayantony
Copy link
Contributor

@shizhMSFT @FeynmanZhou - it would be good to start discussing how the ORAS CLI and library can start thinking about using the OCI artifact manifest as well. Having it default to ORAS artifact might make it hard to switch to the OCI artifact manifest if that is approved.

Can we explore what options we have here

  1. Maybe have a config file support in the CLI
  2. Or a flag that that says something like oras push {ref} --oras-artifact
  3. Or consider switching the default and drop the oras-artifact support from the CLI at some point.

All of these have pros and cons and starting that discussion might be useful before switching push to use the artifact spec as default.

@shizhMSFT
Copy link
Contributor

@sajayantony This issue / PR is based on @SteveLasker 's feedback that OCI manifest does not support empty layer array in terms of spec. That's why ORAS artifact manifest becomes the only choice.

@sajayantony
Copy link
Contributor

Yes I understand the decision. I’m asking how do we plan to change the default to use the OCI manifest if that would become the preferred way.

Basically consider how the we keep compatibility with ORAS manifest later.

@SteveLasker
Copy link
Contributor

@sajayantony , are you asking about the pending OCI manifest changes?

@shizhMSFT
Copy link
Contributor

Since we will support OCI manifest & OCI Artifact (opencontainers/image-spec#934), let's postpone this change.

@shizhMSFT shizhMSFT closed this Aug 12, 2022
@shizhMSFT
Copy link
Contributor

Let's re-open this PR if needed later.

@SteveLasker
Copy link
Contributor

The CLI IX is pretty important for the annotations, without blobs scenarios.

@SteveLasker SteveLasker reopened this Aug 12, 2022
@shizhMSFT shizhMSFT added this to the v0.14.0 milestone Aug 15, 2022
@shizhMSFT shizhMSFT added the help wanted Extra attention is needed label Aug 15, 2022
@shizhMSFT
Copy link
Contributor

Closing again as oras-project/oras-go#271 is planned.

@shizhMSFT shizhMSFT closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--artifact-type support in oras push
6 participants