Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new blog post for ORAS v0.15 #61
add a new blog post for ORAS v0.15 #61
Changes from 9 commits
4dd5b5b
099f9bc
ae30582
c3525dd
a92a27c
c7a5829
f306c53
56d4cd7
a4162a4
53c3145
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
$
to be consistent with other commands, enabling users to copy/pasteCould we change the fetch to a tag? Is there a reason we wanted to be overly cryptic with a digest? Nice that digest is supported, but is it the primary scenario?
BTW, does oras support tag to digest discovery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is an output in the command line,
$
is supposed to be added at the beginning. If not, we don't need to add$
.This symbol is used to help readers distinguish between the input command and output.
Yes. The reason we use digest here is that we want to specify the OS/ARCH of
Linux/amd64
for this Docker image. Both digest and tag are supported, it depends on the user's requirement.Do you mean
oras tag [flags] <name>{:<tag>} <new_tag@<digest>>
? Can you clarify this question? Thanks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand the delineation you're trying to make with
$
, but it's really confusing to see. Some commands I can just copy/paste, others will have the$
which I can't paste. I'd suggest KISSing it (Keep It Silly Simple)For the hello-word digest, can you just use the platform architecture tag(hello-world:linux): https://hub.docker.com/_/hello-world/tags
Saying you support digests as well is great. This is another example of keeping it crisp and simple, showing a tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The platform architecture tag(hello-world:linux) is not worked with
oras manifest fetch
after testing it.