Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the potential panic error if there is no platform in the index or manifest list #695

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix: fix the potential panic error if there is no platform in the index or manifest list #695

merged 2 commits into from
Jan 25, 2024

Conversation

lizMSFT
Copy link
Contributor

@lizMSFT lizMSFT commented Jan 25, 2024

resolves #692

@lizMSFT
fix: fix the potential panic error if there is no platform in the ind…
1b64aef 
…ex or manifest list

Signed-off-by: Zoey Li <zoeyli@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (66ea3df) 75.88% compared to head (1b64aef) 75.87%.

❗ Current head 1b64aef differs from pull request most recent head 9a15291. Consider uploading reports for the commit 9a15291 to get more accurate results

Files Patch % Lines
internal/platform/platform.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   75.88%   75.87%   -0.01%     
==========================================
  Files          59       59              
  Lines        5868     5874       +6     
==========================================
+ Hits         4453     4457       +4     
- Misses       1038     1039       +1     
- Partials      377      378       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizMSFT
add ut
9a15291 
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qweeah
qweeah approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wwwsylvia
Wwwsylvia approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit fa548ab into oras-project:main Jan 25, 2024
7 checks passed
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah approved these changes

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] index or manifest list without the OPTIONAL field platform cause panic
4 participants
@lizMSFT @qweeah @Wwwsylvia @shizhMSFT