feat: error type for not finding basic auth creds and export config path #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
+ Coverage 75.71% 75.78% +0.06%
==========================================
Files 59 59
Lines 5765 5769 +4
==========================================
+ Hits 4365 4372 +7
+ Misses 1028 1026 -2
+ Partials 372 371 -1 ☔ View full report in Codecov by Sentry. |
shizhMSFT
reviewed
Jan 10, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
requested review from
sajayantony,
SteveLasker and
Wwwsylvia
as code owners
Wwwsylvia
reviewed
Jan 12, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Wwwsylvia
reviewed
Jan 12, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
|
I think this change is a |
qweeah
changed the title
qweeah
changed the title
shizhMSFT
reviewed
Jan 15, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Jan 16, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes proposed in this PR
An example usage of the proposed change: oras-project/oras#1235, resolves #676