Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error handling when delete non-existent target #627

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix: error handling when delete non-existent target #627

merged 3 commits into from
Oct 25, 2023

Conversation

wangxiaoxuan273
Copy link
Contributor

resolves #626

@wangxiaoxuan273
fix: error handling when delete
cbfdc47 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #627 (28036c1) into main (0f1dc30) will increase coverage by 0.02%.
The diff coverage is 85.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   75.09%   75.12%   +0.02%     
==========================================
  Files          59       59              
  Lines        5421     5427       +6     
==========================================
+ Hits         4071     4077       +6     
  Misses        995      995              
  Partials      355      355
Files Coverage Δ
content/oci/storage.go 62.79% <85.71%> (+1.54%) ⬆️

... and 1 file with indirect coverage changes

shizhMSFT
shizhMSFT reviewed Oct 24, 2023
View reviewed changes
content/oci/storage.go Outdated Show resolved Hide resolved
@wangxiaoxuan273
resolved toctou
fb01267 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
shizhMSFT
shizhMSFT reviewed Oct 24, 2023
View reviewed changes
content/oci/storage.go Outdated Show resolved Hide resolved
@wangxiaoxuan273
resolved comments
28036c1 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
shizhMSFT
shizhMSFT approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wwwsylvia
Wwwsylvia approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia closed this Oct 25, 2023
@Wwwsylvia Wwwsylvia reopened this Oct 25, 2023
@Wwwsylvia
Copy link
Member

Sorry, accidentally clicked "close", thought it was "merge"...
image

@Wwwsylvia Wwwsylvia merged commit bdea1ff into oras-project:main Oct 25, 2023
12 checks passed
@wangxiaoxuan273 wangxiaoxuan273 deleted the better-error-handling branch October 26, 2023 09:19
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oci.Storage.Delete() should return ErrNotFound if target is not present in the storage
4 participants
@wangxiaoxuan273 @codecov-commenter @Wwwsylvia @shizhMSFT