Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support deletion for OCI storage #608

Merged
merged 2 commits into from
Oct 7, 2023
Merged

feat: support deletion for OCI storage #608

merged 2 commits into from
Oct 7, 2023

Conversation

wangxiaoxuan273
Copy link
Contributor

Signed-off-by: Xiaoxuan Wang wangxiaoxuan119@gmail.com

Part 3/4 of #454

Based on draft PR #582

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #608 (0f9fe8f) into main (6456d16) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   74.80%   74.77%   -0.03%     
==========================================
  Files          58       58              
  Lines        5306     5313       +7     
==========================================
+ Hits         3969     3973       +4     
- Misses        985      987       +2     
- Partials      352      353       +1
Files Coverage Δ
content/oci/storage.go 61.25% <57.14%> (-0.40%) ⬇️

Wwwsylvia
Wwwsylvia approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxiaoxuan273 wangxiaoxuan273 mentioned this pull request Oct 7, 2023
Merged
@wangxiaoxuan273
feat: support deletion for OCI storage
5a07c7a 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
removed an outdated comment
0f9fe8f 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
TerryHowe
TerryHowe approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 7eef77e into oras-project:main Oct 7, 2023
7 checks passed
@wangxiaoxuan273 wangxiaoxuan273 deleted the oci-storage branch October 8, 2023 01:36
@Wwwsylvia Wwwsylvia mentioned this pull request Oct 19, 2023
Closed
shizhMSFT pushed a commit that referenced this pull request Nov 20, 2023
@wangxiaoxuan273
feat: extend oci.Store with Delete() (#614)
75d200e 
Part 4/4 of #454 

This PR should be reviewed and merged after PR #606 #607 #608

---------

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@Wwwsylvia Wwwsylvia mentioned this pull request Nov 21, 2023
Closed
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangxiaoxuan273 @codecov-commenter @TerryHowe @Wwwsylvia