Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry/remote): implement Mount #500

Merged
merged 1 commit into from
May 8, 2023

Conversation

rogpeppe
Copy link
Contributor

@rogpeppe rogpeppe commented May 5, 2023

This adds support for "mounting" (a.k.a. copy by reference) a blob from one repository to another in the same registry.

As documented in https://docs.docker.com/registry/spec/api/#blob and https://github.com/opencontainers/distribution-spec/blob/main/spec.md#mounting-a-blob-from-another-repository.

I've also manually verified that this works against at least one real registry implementation (zot).

Fixes #337

This implements blob-mount functionality as described

@shizhMSFT shizhMSFT changed the title registry/remote: implement Mount feat(registry/remote): implement Mount May 5, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sign-off your commit to pass the DCO check?

registry/remote/repository.go Outdated Show resolved Hide resolved
registry/remote/repository.go Outdated Show resolved Hide resolved
registry/remote/repository.go Outdated Show resolved Hide resolved
registry/remote/url.go Outdated Show resolved Hide resolved
registry/remote/url.go Outdated Show resolved Hide resolved
registry/remote/url.go Outdated Show resolved Hide resolved
registry/remote/repository.go Outdated Show resolved Hide resolved
registry/remote/repository.go Outdated Show resolved Hide resolved
@sajayantony
Copy link
Contributor

sajayantony commented May 6, 2023

Pinging @Wwwsylvia who I think has a lot of history with mount :). Correct me if I'm wrong Sylvia.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

Pinging @Wwwsylvia for reviewing this PR.

registry/remote/repository.go Outdated Show resolved Hide resolved
registry/remote/repository.go Outdated Show resolved Hide resolved
registry/remote/repository.go Show resolved Hide resolved
@Wwwsylvia
Copy link
Member

@sajayantony You still remember my history with mount😂

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This adds support for "mounting" (a.k.a. copy by reference) a blob
from one repository to another in the same registry.

As documented in https://docs.docker.com/registry/spec/api/#blob
and https://github.com/opencontainers/distribution-spec/blob/main/spec.md#mounting-a-blob-from-another-repository.

I've also manually verified that this works against at least one real registry implementation (zot).

Fixes oras-project#337

This implements blob-mount functionality as described

Signed-off-by: Roger Peppe <rogpeppe@gmail.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit c083b73 into oras-project:main May 8, 2023
@Wwwsylvia Wwwsylvia mentioned this pull request May 24, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support blob mount across repositories
4 participants