Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new internal algorithm interface #521

Merged
merged 94 commits into from
Aug 22, 2024
Merged

Implement the new internal algorithm interface #521

merged 94 commits into from
Aug 22, 2024

Conversation

janosg
Copy link
Member

@janosg janosg commented Aug 10, 2024

The changes are described here

The implementation of InternalOptimizationProblem will deviate a bit from the proposal but those changes do not affect users at all.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@janosg janosg changed the base branch from main to 0.5.0 August 10, 2024 14:47
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 95.86450% with 94 lines in your changes missing coverage. Please review.

Project coverage is 92.53%. Comparing base (24e44a7) to head (3776901).
Report is 1 commits behind head on 0.5.0.

Files Patch % Lines
src/optimagic/optimizers/pygmo_optimizers.py 95.18% 17 Missing ⚠️
...agic/optimization/internal_optimization_problem.py 95.22% 13 Missing ⚠️
src/optimagic/optimizers/nlopt_optimizers.py 94.46% 13 Missing ⚠️
src/optimagic/optimizers/scipy_optimizers.py 96.50% 11 Missing ⚠️
src/optimagic/optimization/history.py 86.95% 9 Missing ⚠️
src/optimagic/optimization/algorithm.py 96.55% 6 Missing ⚠️
src/optimagic/optimizers/ipopt.py 97.12% 6 Missing ⚠️
src/optimagic/optimization/multistart.py 88.57% 4 Missing ⚠️
src/optimagic/batch_evaluators.py 75.00% 3 Missing ⚠️
src/optimagic/optimizers/pounders.py 93.47% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##            0.5.0     #521      +/-   ##
==========================================
+ Coverage   90.88%   92.53%   +1.65%     
==========================================
  Files         107      109       +2     
  Lines       10644    11778    +1134     
==========================================
+ Hits         9674    10899    +1225     
+ Misses        970      879      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

janosg and others added 26 commits August 15, 2024 16:38
@janosg janosg merged commit 43f8488 into 0.5.0 Aug 22, 2024
16 checks passed
@janosg janosg deleted the algorithms branch August 22, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants