Small bug in bootstrap keywords

[alanlujan91]

"cluster" is not a bootstrap option

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (d7d53ec) to head (66a200d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   92.97%   92.98%           
=======================================
  Files         193      193           
  Lines       14635    14638    +3     
=======================================
+ Hits        13607    13611    +4     
+ Misses       1028     1027    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[timmens]

Hey Alan! Thanks for finding this bug and directly providing a fix.

I have only a minor remark about the test, but other than that, it looks great 🎉

[timmens]

I would prefer not to add the cluster_by option test to this block. Here we want to check that the bootstrap kwargs are actually passed to the bootstrap function. I think for the cluster_by argument we would rather want to check that an error is thrown if an invalid option is passed. Maybe you could add something like this below:

with pytest.raises(ValueError, match="Invalid bootstrap_kwargs: {'cluster'}"):
    get_moments_cov(
        data=data,
        calculate_moments=calc_moments,
        moment_kwargs=moment_kwargs,
        bootstrap_kwargs={"cluster": "cluster"},
    )

[timmens]

Thanks a lot!