Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batches #459

Merged
merged 11 commits into from
Apr 20, 2023
Merged

Batches #459

merged 11 commits into from
Apr 20, 2023

Conversation

mpetrosian
Copy link
Member

@mpetrosian mpetrosian commented Apr 15, 2023

  • Add batch counter to optimization histories
  • Add n_batches as possible runtime for benchmark plots

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #459 (e4e6d5b) into main (582caa4) will increase coverage by 0.01%.
The diff coverage is 97.16%.

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   93.26%   93.27%   +0.01%     
==========================================
  Files         247      247              
  Lines       18000    18045      +45     
==========================================
+ Hits        16787    16831      +44     
- Misses       1213     1214       +1     
Impacted Files Coverage Δ
src/estimagic/optimization/tranquilo/tranquilo.py 97.26% <ø> (ø)
tests/visualization/test_convergence_plot.py 100.00% <ø> (ø)
tests/visualization/test_deviation_plot.py 100.00% <ø> (ø)
src/estimagic/visualization/convergence_plot.py 88.52% <50.00%> (-1.31%) ⬇️
tests/optimization/test_history_collection.py 98.41% <97.29%> (-1.59%) ⬇️
src/estimagic/optimization/get_algorithm.py 93.10% <97.77%> (+0.13%) ⬆️
...stimagic/benchmarking/process_benchmark_results.py 95.65% <100.00%> (+0.09%) ⬆️
src/estimagic/benchmarking/run_benchmark.py 93.90% <100.00%> (+0.15%) ⬆️
...imagic/optimization/internal_criterion_template.py 83.09% <100.00%> (+0.61%) ⬆️
src/estimagic/visualization/deviation_plot.py 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@janosg janosg requested a review from timmens April 15, 2023 15:33
@janosg janosg merged commit 164264e into main Apr 20, 2023
@janosg janosg deleted the runtime-batches branch April 20, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants