-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #4938: Language Selection Config and New Profile Creation Flow #5457
base: develop
Are you sure you want to change the base?
Conversation
…boarding-profile-type-screen
…boarding-profile-type-screen # Conflicts: # app/src/main/res/values/component_colors.xml # scripts/assets/test_file_exemptions.textproto
…d into onboarding-profile-type-screen
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 13 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 12 KiB (Added) Method count: 258445 (old), 258861 (new), 416 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6776 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 13 KiB (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 7708 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 3036 bytes (Added) Method count: 114844 (old), 115074 (new), 230 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 7712 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 7664 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 9052 bytes (Added) Method count: 114850 (old), 115080 (new), 230 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 7672 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 7552 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 8554 bytes (Added) Method count: 114850 (old), 115080 (new), 230 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 7552 bytes (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 15 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 14 KiB (Added) Method count: 258445 (old), 258966 (new), 521 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6776 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 15 KiB (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 6149 bytes (Added) Method count: 114844 (old), 115126 (new), 282 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 9617 bytes (Added) Method count: 114850 (old), 115132 (new), 282 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 10 KiB (Added) Method count: 114850 (old), 115132 (new), 282 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
Use an observable field to dynamically update errors.
Pass extras creation to the calling method
Tests for locale, config change, selections and default selection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review pass
app/src/main/java/org/oppia/android/app/translation/AppLanguageResourceHandler.kt
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/options/AudioLanguageFragmentTest.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/profile/ProfileManagementController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/onboarding/CreateProfileViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingFragmentTest.kt
Show resolved
Hide resolved
@@ -271,6 +271,7 @@ file_content_checks { | |||
exempted_file_name: "app/src/main/java/org/oppia/android/app/player/audio/LanguageDialogFragment.kt" | |||
exempted_file_name: "app/src/sharedTest/java/org/oppia/android/app/administratorcontrols/AppVersionActivityTest.kt" | |||
exempted_file_name: "app/src/sharedTest/java/org/oppia/android/app/home/HomeActivityTest.kt" | |||
exempted_file_name: "app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingFragmentTest.kt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning, not sure there is a way to use OppiaLocale in forcing default locale in tests, so I exempted the test file from this check.
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 16 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 16 KiB (Added) Method count: 258445 (old), 258969 (new), 524 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6776 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 16 KiB (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 4392 bytes (Added) Method count: 114844 (old), 115132 (new), 288 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 9034 bytes (Added) Method count: 114850 (old), 115138 (new), 288 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 9666 bytes (Added) Method count: 114850 (old), 115138 (new), 288 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
1 similar comment
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 16 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 16 KiB (Added) Method count: 258445 (old), 258969 (new), 524 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6775 (old), 6776 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 16 KiB (Added)
Configuration hdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 4392 bytes (Added) Method count: 114844 (old), 115132 (new), 288 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 9034 bytes (Added) Method count: 114850 (old), 115138 (new), 288 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 9666 bytes (Added) Method count: 114850 (old), 115138 (new), 288 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5745 (old), 5746 (new), 1 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 10 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
Explanation
Fixes Part of #4938: Modifies the profile creation flow and sets the app/audio language selection during onboarding.
Default Profile Creation
A default empty profile is created when the Onboarding screen is opened for the first time. This is necessary to provide a ProfileId to use when saving the selected app language.
Because this will be the first profile on the app in onboarding v2, it is an admin.
Provisions have been made so that, should the user exit the app before completing the onboarding flow, this profile will be fetched, to prevent multiple profile creation.
App Language Selection
The language selector will be shown to the user on initial app launch, or if profile onboarding is not complete.
Tests have been added to verify these requirements, and efforts have been made to ensure language selection persists on configuration change. I noticed during testing that failure to do this resulted in an unpleasant UX.
Profile Nickname and Picture
The "Create profile Screen" has been repurposed to update the default profile instead, providing the remaining profile properties(ProfileType, name, avatar)
Checks have been added to check for profile creation errors, consistent with the legacy flow.
A new function has been added to the ProfileManagementController to allow for batch update of these fields, and corresponding tests have been added.
Audio Language Selection
The final step of onboarding is the audio language selection, and there will be a pre-filled language selectionas follows:
There have been some incidental changes in AudioLanguageFragment and OptionsFragment, and their related tests due to sharing of the classes between the existing screens and the new screens.
ProfileTestHelper.kt
A new function, and related tests, have been added to create a default profile to be used in tests.
Essential Checklist
For UI-specific PRs only
TODO: Add screen recordings
If your PR includes UI-related changes, then: